WebDialog encoding bug found!

[driven]

thanks dan

You need a platform code branch and use element.innerText= on PC.

innerText works on mac, so I'll just change that...

can you run

show_encoding_issue.rb

and see if they show in the dialog...

the extra // in your console return confuses me. I had to add more to escape ruby escaping javascript...

john

[Dan Rathbun]

OK, that latest tweek, after hitting enter:

WebDialog_param_encoding_fix3_after_enter.png

And the console, after hitting enter:
load "test/show_encoding_issue.rb"
true
return using add_action_callback
"lid1,\\u00E9lan \\u52E2\\u3044 Schwung \\u0438\\u043C\\u043F\\u0443\\u043B\\u044C\\u0441"
return using get_element_value => \u00E9lan \u52E2\u3044 Schwung \u0438\u043C\u043F\u0443\u043B\u044C\u0441


BTW.. if the WebDialog has focus after hitting ENTER, and I need to use the ALT key (for ALT+PrintScreen to copy the active window image to the clipboard, so I can save it from Paint.NET,) there is a whole bunch of repeated console output, like 15 times while I held the ALT key down.

[driven]

yeh it works...

BTW.. if the WebDialog has focus after hitting ENTER, and I need to use the ALT key (for ALT+PrintScreen to copy the active window image to the clipboard, so I can save it from Paint.NET,) there is a whole bunch of repeated console output, like 15 times while I held the ALT key down.

with this should I just add a screen grab and dump it to desktop?

Code: Select all

    @dlg2.write_image(File.join((File.expand_path("~")), "Desktop", "dlg_test.png"))


dlg_test.png

what's the PC equiv...
EDIT: for completeness I'll add the unmodified pair back into the mix after sleep...
thanks again dan
john

[Dan Rathbun]

... should I just add a screen grab and dump it to desktop?

NO.

Replace the onkeydown= with:
onkeyup=" if (event.keyCode == 13) { this.value=unicodeLiteral(this.value); trans_L8(); }"

Notice that I enclose BOTH the following statements within a "curly block", so that the test only fires when ENTER key is released (after being pressed.)
The condition will not even be tested while any key is down, including any modifier key.

[Dan Rathbun]

FYI: I am one of those who hates programs putting stuff on MY Desktop.

[driven]

FYI: I am one of those who hates programs putting stuff on MY Desktop.

so do I so I added it as a button...
NEW VERSION...
I split the input method to make it function the same in all versions of SU...
I can't get the raw code too display in the dialog, so here it is for v2014, the others are similarly wrong...
EDIT: made a small adjustment to get 'fixed' to display correctly [puts v p]

Code: Select all

true
return using add_action_callback [id,value]
"\xE2\x88\x9A\xC2\xA9lan \xC3\x82\xC3\xA3\xC2\xA2\xE2\x80\x9E\xC3\x85\xC3\x91 Schwung \xE2\x80\x93\xE2\x88\x8F\xE2\x80\x93\xC2\xBA\xE2\x80\x93\xC3\xB8\xE2\x80\x94\xC3\x89\xE2\x80\x93\xC2\xAA\xE2\x80\x94\xC3\xA5\xE2\x80\x94\xC3\x85"
return using get_element_value => élan 勢い Schwung импульс
return using add_action_callback [id,value_fixed]
\u00E9lan \u52E2\u3044 Schwung \u0438\u043C\u043F\u0443\u043B\u044C\u0441
return using get_element_value fixed => \u00E9lan \u52E2\u3044 Schwung \u0438\u043C\u043F\u0443\u043B\u044C\u0441

encoding_issue_14.0.4899.png

encoding_issue_13.0.4811.png

encoding_issue_8.0.16845.png

Please test the new script...

show_encoding_issue.rb

john

[TIG]

Here are my PC results.
Win7 IE11.
Note how v2014 misses platform ?
Only the v8 Russian text seems to have a problem on get_element_value ??

[Garry K]

Here you go.
I've got SU 7 Free, SU 8 Free, SU 2013 Trial, SU 2014 Trial

[Garry K]

Sorry - missed clicking the button for SU 7

[driven]

Thanks Tig and Garry,

from your images it appears that v8 had an issue with the standard call but shows correctly if SU is handed a Unicode charset string with it's separators gsub'd.

The ongoing v2014 (PC) handles both standard or 'fixed', where my mac's fail.

I'll write up a bug report for this, and at least I can now carry on with my language translator...

The only conditions, in this script, are for the 'extra' system info, which I won't need...

@garry, if you click into the text field, then hit return and then click the button, you'll see the default results as well...

I had to split them onto Two buttons for v8 to use the same code as the others...

john

[fredo6]

Here are my results on SU14, Windows 7 64-bits, IE11

1) When starting Sketchup

Driven encoding UTF - Fredo - 0.png

2) After putting the focus in the field and typing Enter

Driven encoding UTF - Fredo.png

Fredo

[driven]

Thanks Fredo,

I updated the script since then to shows both the default and fixed returns...

the default shows with the return from the input box and the button shows the 'fix' i.e. Unicode literals with separators fixed...

on the PC it appears v8 may have an issue with the 'default' return for 'get_element_value' some of these chars, and mac has issues on all versions, but the Unicode literals appear to work on all, so far...

Thanks for taking the time.

john

show_encoding_issue_1404022050.rbz

[fredo6]

Driven,

Here is the result with the updated script


1) Initial state

Encoding issue before.png

2) After hitting the button

Encoding issue after Enter in the field.png

Fredo

[greatoe]

Sketchup 2014
Mac 10.9.2
testing text in Simplified Chinese

encoding_issue_14.0.4899.png