[Plugin] CleanUp

Re: [Plugin] Cleanup (1.1.2) — 23 October 2009

Postby thomthom » Tue Feb 09, 2010 9:58 am

Thanks Sean.
So you're still using SU? I thought you'd gone all Max now?
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: [Plugin] Cleanup (1.1.2) — 23 October 2009

Postby free agent » Tue Feb 09, 2010 10:21 am

yup still using SU, some things are still way quicker with a face modeler than a solid modeler, i doubt it will ever be out of my workflow, i wish u were writing max script, there are alot of sketchup like actions i would like to see available in max... but i have to work with what i have i guess :) thanx again for this script :thumb:
0
User avatar
free agent 
 

Re: [Plugin] Cleanup (1.1.2) — 23 October 2009

Postby thomthom » Tue Feb 09, 2010 10:26 am

Well, the office is making more and more Revit models. And importing them into SU is a workflow nightmare. So I'm very tempted to get Max into my office toolkit. ...so who knows... ;)

Btw, got any new renders to show off?
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: [Plugin] Cleanup (1.1.2) — 23 October 2009

Postby free agent » Tue Feb 09, 2010 11:35 am

please contact me when u take the plunge into maxscript, im sure its easier, definitly a bigger user base, do it do it do it!!!


i got a couple, should i email? :P
0
User avatar
free agent 
 

Re: [Plugin] Cleanup (1.1.2) — 23 October 2009

Postby thomthom » Tue Feb 09, 2010 12:14 pm

email or make a post in the gallery. I'm always curious to see what you produce.
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: [Plugin] Cleanup (1.1.2) — 23 October 2009

Postby Gaieus » Wed Mar 17, 2010 2:21 pm

Hi Thom,

There is an "unwanted" feature in this plugin (I do not necessarily want to call it a "bug"); it erases coplanar edges also when that edge divides faces where the same material applied but positioned differently. See screenshots attached.

Cleanup1.jpg

Cleanup2.jpg

Could there be at least a setting that prevents this? I was making an arched surface for this vault when I first discovered this - it simply erased all the dividing edges and of course screwed up the arch big time.

arch.jpg

Thanks for looking into this issue - this is the best ever cleanup script I have ever encountered. aybe abother wish - could there be a feature/setting to clean up only whatever is in context (like inside a goup) and/or in a certain selection?
Or maybe I missed something?
0
User avatar
Gaieus 
 

Re: [Plugin] Cleanup (1.1.2) — 23 October 2009

Postby thomthom » Wed Mar 17, 2010 2:42 pm

Gaieus wrote:There is an "unwanted" feature in this plugin (I do not necessarily want to call it a "bug"); it erases coplanar edges also when that edge divides faces where the same material applied but positioned differently. See screenshots attached.

hmm... Yes - I see how this can be an issue. Will need to ponder on how to avoid this though.

Gaieus wrote:Thanks for looking into this issue - this is the best ever cleanup script I have ever encountered. aybe abother wish - could there be a feature/setting to clean up only whatever is in context (like inside a goup) and/or in a certain selection?
Or maybe I missed something?

CleanUp.png

Yea - the UI is horrible.
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: [Plugin] Cleanup (1.1.2) — 23 October 2009

Postby Gaieus » Wed Mar 17, 2010 2:54 pm

Hm. Can I have another (older?) version?

cleanup.png
0
User avatar
Gaieus 
 

Re: [Plugin] Cleanup (1.1.2) — 23 October 2009

Postby thomthom » Wed Mar 17, 2010 3:27 pm

No - I seem to have extra menu items from working on v1.2.0 oopsie
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: [Plugin] Cleanup (1.1.2) — 23 October 2009

Postby Gaieus » Thu Mar 18, 2010 10:03 am

:lol:
_______

I tried to lock such faces with positioned materials but the script erases lines in locked groups, too! :o
0
User avatar
Gaieus 
 

Re: [Plugin] Cleanup (1.1.2) — 23 October 2009

Postby thomthom » Thu Mar 18, 2010 10:46 am

Gaieus wrote:I tried to lock such faces with positioned materials but the script erases lines in locked groups, too! :o

That's interesting. Another thing to note down.
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: [Plugin] Cleanup (1.2.0) — 23 April 2010

Postby thomthom » Fri Apr 23, 2010 10:41 pm

Armed with more info from Simone Nicolo I now have a better method for detecting coplanar faces - the same method Sketchup use. I think it's 100% reliable. No more messing about with tolerances. :berserk:

Highly recommended update!
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: [Plugin] Cleanup (1.2.0) — 23 April 2010

Postby thomthom » Fri Apr 23, 2010 10:57 pm

thomthom wrote:Armed with more info from Simone Nicolo I now have a better method for detecting coplanar faces - the same method Sketchup use. I think it's 100% reliable. No more messing about with tolerances. :berserk:

Highly recommended update!


:( Turns out it's not 100%. In one of my test model it still left some edges that could be erased.

Updated with some minor UI fixes.
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: [Plugin] Cleanup (1.2.1) — 23 April 2010

Postby EscapeArtist » Fri Apr 23, 2010 10:58 pm

"The selected attachment does not exist anymore"

Error when clicking for download.
0
User avatar
EscapeArtist 
Top SketchUcator
 

Re: [Plugin] Cleanup (1.2.1) — 23 April 2010

Postby thomthom » Fri Apr 23, 2010 11:06 pm

EscapeArtist wrote:"The selected attachment does not exist anymore"

Error when clicking for download.

You probably tried to download just as I uploaded a quick patch. :oops:
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: [Plugin] Cleanup (1.2.1) — 23 April 2010

Postby CadFather » Fri Apr 23, 2010 11:09 pm

Thanks Thom, this is good.
0
Quarr-IT - SketchUp Training from the Master.. http://quarr-it.com/
User avatar
CadFather 
PluginStore Author
PluginStore Author
 

Re: [Plugin] Cleanup (1.2.1) — 23 April 2010

Postby EscapeArtist » Sat Apr 24, 2010 4:00 am

thomthom wrote:You probably tried to download just as I uploaded a quick patch. :oops:


Ah, timing is everything. Works just fine. Thanks!
0
User avatar
EscapeArtist 
Top SketchUcator
 

Re: [Plugin] Cleanup (1.2.1) — 23 April 2010

Postby MtnTrails » Sat Apr 24, 2010 6:46 am

:thumb: Thank you, Thom! Works just like I'd hoped. What a great time saver! :sketchstatic:
0
-Brian

Keep doing what you're doing and you'll keep getting what you're getting.

MtnTrails 
 

Re: [Plugin] Cleanup (1.2.1) — 23 April 2010

Postby Gaieus » Sat Apr 24, 2010 8:52 am

Hi Thom,

Thanks for the update. I'll definitely try it out (I managed to forget about two coplanar faces with differently positioned but the same texture again and screwed up my model - no big hassle though just a "doh" moment again...)
:D
0
User avatar
Gaieus 
 

Re: [Plugin] Cleanup (1.2.1) — 23 April 2010

Postby thomthom » Sat Apr 24, 2010 10:57 am

Gaieus wrote:Hi Thom,

Thanks for the update. I'll definitely try it out (I managed to forget about two coplanar faces with differently positioned but the same texture again and screwed up my model - no big hassle though just a "doh" moment again...)
:D

Ah yes - I'm still not sure how to account for that. But it is possible ... somehow...
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: [Plugin] Cleanup (1.2.1) — 23 April 2010

Postby Rich O Brien » Sat Apr 24, 2010 11:03 am

Hi Thom,

Thanks for the update, one of my favourite plugins.
Doesnt say much about my modelling ability!
0
There's a frontroom and a backroom....reverse faces
User avatar
Rich O Brien 
Administrator
 

Re: [Plugin] Cleanup (1.2.2) — 24 April 2010

Postby thomthom » Sat Apr 24, 2010 4:10 pm

Important update in 1.2.2
Sorry for all these updates recently.
I think I found the root of why the last update wasn't 100%.

It now erases edges as they are processes, instead of in bulk later. This is because each face's plane equations must be re-evaluated after it's been merged. This might lead to slightly longer processing time - but I now hope that it truly is 100% watertight.
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: [Plugin] Cleanup (1.2.2) — 24 April 2010

Postby EarthMover » Sat Apr 24, 2010 7:39 pm

Thanks for the update. I use this puppy all the time! :thumb:
0
3D Artist at Clearstory 3D Imaging
Guide Tool at Winning With Sketchup
Content Creator at Skapeup
User avatar
EarthMover 
Premium Member
Premium Member
 

Re: [Plugin] Cleanup (1.2.2) — 24 April 2010

Postby Jim » Sun Apr 25, 2010 3:07 pm

Thanks - it is doing better job of removing edges. I am willing to trade a little extra time for a cleaner model.

I did get a reference to a deleted Edge error on this model (.stl import.) I haven't investigated the cause, but I've attached it in case you're curious.

Error: #<TypeError: reference to deleted Edge>
C:\Program Files\Google\Google SketchUp 7\Plugins\tt_cleanup.rb:283:in `faces'


My fix:
283: next unless e.valid? and e.is_a?(Sketchup::Edge)

But is doesn't explain the cause.
0
Hi

Jim 
Global Moderator
 

Re: [Plugin] Cleanup (1.2.2) — 24 April 2010

Postby thomthom » Sun Apr 25, 2010 4:09 pm

hm.. that is odd. I wonder why that happens. thanks for posting the model.
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: [Plugin] Cleanup (1.2.3) — 25 April 2010

Postby thomthom » Sun Apr 25, 2010 6:14 pm

Updated to account for the issue reported by Jim.

Though I still don't understand why I ever get a reference to a deleted edge...
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: [Plugin] Cleanup (1.2.3) — 25 April 2010

Postby TIG » Sun Apr 25, 2010 9:14 pm

Trap unexpected deleted edges with edge.erase! if edge.valid? type of code ?
0
TIG
User avatar
TIG 
Global Moderator
 

Re: [Plugin] Cleanup (1.2.3) — 25 April 2010

Postby thomthom » Sun Apr 25, 2010 9:55 pm

Yes - but what puzzles me is why the code comes across deleted references at all. After reviewing my code I can't work out why. I am iterating an array copy of the entities collection. And I only iterate the array once.
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: [Plugin] Cleanup (1.3.0) — 26 April 2010

Postby thomthom » Mon Apr 26, 2010 10:51 pm

Gaieus: This update is for you. Made it investigate the UV's before merging.
Not that it is very strict, the UV values for either vertex of the edge has to be identical for each face connected to it before it merges. This means there might be cases where it visually looks like they should merge, but doesn't. They should merge is you position a material on one face and use the dropper to paint other adjacent faces.
To turn of this feature just enable the Ignore UV's.

Note that this is pretty fresh code that hasn't been tested well. (Only very quickly.) So please investigate the model after using the tool and report any unexpected behaviour. (Please most sample model as that will make debugging much easier.)
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: [Plugin] Cleanup (1.3.0) — 26 April 2010

Postby Ern » Tue Apr 27, 2010 2:30 am

Very handy,
0

Ern 
 

SketchUcation One-Liner Adverts

by Ad Machine » 5 minutes ago



Ad Machine 
Robot
 

PreviousNext


 

Return to Plugins

Who is online

Users browsing this forum: abdulboji, hafizh_shahab, karinfeder, randomwolf45, remziii, yenyenrosales and 11 guests

Visit our sponsors: