Library Directory Structure

Moderator: Jim

Library Directory Structure

Postby Jim » Thu Jun 18, 2009 8:01 pm

There seems to be a consensus forming that organizing related methods into a single file is the preferred way people want to work with the library. That's OK with me.

Currently, there is a a folder for each Sketchup class, and individual methods reside in their own files in the folders.

Are we agreed on switching to one-file-per-sketchup-class? If so, I will get started on it.
0
Hi

Jim 
Global Moderator
 

Re: Library Directory Structure

Postby Chris Fullmer » Thu Jun 18, 2009 8:14 pm

I think so, I'd say go for it!

Chris
0
Lately you've been tan, suspicious for the winter.
All my Plugins I've written
User avatar
Chris Fullmer 
SketchUp Team
SketchUp Team
 

Re: Library Directory Structure

Postby thomthom » Thu Jun 18, 2009 8:18 pm

:thumb:


Are we doing this Review thing? Adding new methods to a review folder before they are verified to be put into the main?
(Isn't there a code review functionality for this? If I get this right, you add files to a new head/trunk/branch (whatever the name is) and then Request Code Review?) So that we don't need a separate folder - just merge the changes as they are accepted?
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: Library Directory Structure

Postby Jim » Thu Jun 18, 2009 8:24 pm

thomthom wrote:Are we doing this Review thing? Adding new methods to a review folder before they are verified to be put into the main?


I'm not sure. I was thinking too that I wouldn't mind having my own 'jim' folder in the repo to keep experimental files, and things I might want to ask someone to look at.

I like the idea of a 'review' folder, you know everything in there is pending and needs reviewed. I don't know if it is needed and will only clutter up the folder.
0
Hi

Jim 
Global Moderator
 

Re: Library Directory Structure

Postby Chris Fullmer » Thu Jun 18, 2009 8:35 pm

I also like the idea of the review feature. I feel like I tried to use it and failed miserably so far. So when you guys figure it out, let me know.

I'm also making some "major" changes to citygen and finding that I am undesratnding the importance of keeping a clean version of citygen and then my messed up version separate. Little by little this will make sense to me....

Chris
0
Lately you've been tan, suspicious for the winter.
All my Plugins I've written
User avatar
Chris Fullmer 
SketchUp Team
SketchUp Team
 

Re: Library Directory Structure

Postby thomthom » Thu Jun 18, 2009 8:47 pm

Chris: how did you create the Bezier branch?
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: Library Directory Structure

Postby Chris Fullmer » Thu Jun 18, 2009 8:50 pm

I Tortoise, on the Synch window, there is a place to enter the branch name. I just entered "bezier" in there.

But then I tried to request a review of the "bezier" branch, but it wouldn't recognize the path. Jim thought maybe its a googlecode problem, something they don't have fully implemented. I figured it just had to do with how I tried to do it - user error.

Chris
0
Lately you've been tan, suspicious for the winter.
All my Plugins I've written
User avatar
Chris Fullmer 
SketchUp Team
SketchUp Team
 

Re: Library Directory Structure

Postby thomthom » Thu Jun 18, 2009 9:38 pm

"Target Revision"?
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: Library Directory Structure

Postby Jim » Thu Jun 18, 2009 9:50 pm

Branching seems a rather ambiguous concept. When you clone a repository, make any change, and commit it - that is a branch because your clone is now different than the original.

What you did with 'bezier' is create a named branch. I don't know how to use them, or how they might benefit.
0
Hi

Jim 
Global Moderator
 

Re: Library Directory Structure

Postby Jim » Fri Jun 19, 2009 1:00 am

Well, that went about as well as could be expected. That means it DID go well and the repo has been updated.


http://code.google.com/p/skx/source/browse/
0
Hi

Jim 
Global Moderator
 

Re: Library Directory Structure

Postby thomthom » Fri Jun 19, 2009 7:18 am

Is there no way to get rid of the old folders?
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: Library Directory Structure

Postby Jim » Fri Jun 19, 2009 12:55 pm

thomthom wrote:Is there no way to get rid of the old folders?


I thought I did. They are gone for me, anyway.

When I rename files, I use the mercurial commands hg rename to rename them.

Code: Select all
$ hg rename entities/all_entities.eb entities.rb


When I renamed the last filein the folder, the folder was gone from my working directory.

I don't know why you still have them, or if you should just delete them. But I think you could. mercurial doesn't track folders, just files.

You can always make a quick clone and see what happens.
0
Hi

Jim 
Global Moderator
 

Re: Library Directory Structure

Postby thomthom » Fri Jun 19, 2009 1:09 pm

The folders in my own library are done.
But it's the Google Browse view that still lists them.
0
Thomas Thomassen — SketchUp Monkey & Coding addict
List of my plugins and link to the CookieWare fund
User avatar
thomthom 
PluginStore Author
PluginStore Author
 

Re: Library Directory Structure

Postby Jim » Fri Jun 19, 2009 1:20 pm

I'm not sure if that is because of Google Code, or because those folder exists in the history. I do know if you clone the repository at this changeset, you do not get the empty folders.
0
Hi

Jim 
Global Moderator
 

SketchUcation One-Liner Adverts

by Ad Machine » 5 minutes ago



Ad Machine 
Robot
 



 

Return to Skx Extension Library

Who is online

Users browsing this forum: No registered users and 1 guest

Visit our sponsors: